Skip to content

[PWGLF] Add customV0 pairing for Sigma+ PCM photon - #18175

Merged
romainschotter merged 3 commits into
AliceO2Group:masterfrom
hfribert:sigmaplus-customV0
Oct 6, 2026
Merged

[PWGLF] Add customV0 pairing for Sigma+ PCM photon#18175
romainschotter merged 3 commits into
AliceO2Group:masterfrom
hfribert:sigmaplus-customV0

Conversation

@hfribert

@hfribert hfribert commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@fmazzasc

This PR adds the option to build the photon candidates itself instead of using V0Datas:

  • This is needed since the SVertexer is built for V0's from the primary vertex, which is not the case for the Sigma+'s photon (weak decay: Sigma+ --> p + pi0 --> p + 2 gamma (only 1 gamma reconstructed)). In MC local tests, this yields ~3x as many true Sigma+ as the V0Datas.
  • Pairing similar to the SVertexer: precuts on the daughters' polar angle difference and on the circles touching, then a vertex fit in every compatible collision (TPC-only daughters moved to the collision time, as in the strangenessbuilder)
  • For TPC-only daughters, the compatible collisions are taken from their full TPC time range
  • The proton daughter determines the collision (has ITS). For the photon deduplication (same photon in several candidates), only the Sigma+ candidate with the smallest DCA of the reconstructed mother to the PV is written
  • Also included additional photon & candidate variables, as well as histograms, for the direct comparison between the two different methods and for additional cuts in post-analysis

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@hfribert
hfribert marked this pull request as ready for review October 5, 2026 14:36
romainschotter
romainschotter approved these changes Oct 5, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx
Comment thread PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx
romainschotter
romainschotter requested changes Oct 5, 2026
View reviewed changes

@romainschotter romainschotter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry misclick)

@alibuild

alibuild commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3502361 at 2026-10-06 04:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 7 warnings.'
Found 8 errors and 7 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/2b0618f0fcc10ac2301a80bc9fdd835e7d2dac7c/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:303:28: error: no header providing "TAxis" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:304:12: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:310:29: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:333:29: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:642:33: error: no header providing "o2::aod::track::extensions::TPCTimeErrEncoding" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:707:21: error: no header providing "o2::math_utils::CircleXYf_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:730:43: error: no header providing "o2::aod::track::TrackTimeAsym" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:784:77: error: no header providing "o2::constants::lhc::LHCBunchSpacingNS" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/2b0618f0fcc10ac2301a80bc9fdd835e7d2dac7c/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:416:26: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:642:5: warning: uninitialized record type: 'timeEncoding' [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:643:27: warning: do not access members of unions; consider using (boost::)variant instead [cppcoreguidelines-pro-type-union-access]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:656:21: warning: use designated initializer list to initialize 'TrackCand' [modernize-use-designated-initializers]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:690:33: warning: use designated initializer list to initialize 'SVCand' [modernize-use-designated-initializers]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:1348:37: warning: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead [bugprone-incorrect-roundings]
PWGLF/TableProducer/Strangeness/sigmaplusbuilder.cxx:1707:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

@hfribert Please fix the errors before merging.

@romainschotter

romainschotter commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Hi @hfribert !
You are right, the propagationService relies on V0s from the SVertexer and thus on photons which are primary. The best would actually be to have a dedicated builder for secondary TPC-only V0s. This would thus be beneficial for others. Okay, in the meantime, once the includes in the task are fixed, I will merge the PR.

Out of curiosity, how large is the effect of the cut on the DCA V0 to PV in the SVertexer?

By the way, you should also consider giving a presentation at the next PAG-Strangeness such that we can further discuss the analysis details.

Thank you very much!

@hfribert

hfribert commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi @romainschotter!
From the local tests, it looks like about 40% of the photons (which ultimately yield a valid reconstructed sigma) are removed by the dca-to-PV cut.
Indeed, a presentation at the PAG sounds useful, maybe I can prepare something for next week with additional QA plots.

Just to give already some context for the analysis, the goal is to perform p-Sigma+ femtoscopy, initially planned to be done by reconstructing the sigma+ using the new kink reconstruction method. This kink analysis worked really well for p-sigma- but seems to yield quite little statistics for sigma+, due to the shorter lifetime, branching ratio, and decay kinematics. So we are now looking into this PCM reconstruction (which was used for the Run2 p-Sigma+ femto results) to see whether it can yield more than the kink approach (or add to it) and to ensure we are not missing any statistics.

Thanks a lot!

@romainschotter
romainschotter enabled auto-merge (squash) October 6, 2026 09:50
@vkucera

vkucera commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

@hfribert Thank you for the fixes!

@romainschotter
romainschotter merged commit 9939e9f into AliceO2Group:master Oct 6, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hfribert @alibuild @vkucera @romainschotter